[FFmpeg-devel] [PATCH] avcodec/libx265: allow 12bit input formats, update warnings

[Stephen Hutchinson]

On 7/9/2015 11:58 AM, Derek Buitenhuis wrote:
> Hi,
>
> Apologies if this comes through as HTML. I am internet-less and
> using the Gmail web interface.
>
> On Wed, Jul 8, 2015 at 11:54 PM, Steve Borho <steve at borho.org> wrote:
>> The range extension profiles have been fully ratified so there
>> is no reason to require -strict experimental for them. However
>> Main12 support in x265 is experimental so I check for that
>> instead.
>
> [...]
>
>> -    if (avctx->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL &&
>> -        !av_pix_fmt_desc_get(avctx->pix_fmt)->log2_chroma_w) {
>> +    if (avctx->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL && ctx->api->bit_depth == 12) {
>
> Style nit: Add a break like it previously had.
>

It seems as though x265 no longer warns about 12-bit
as experimental as of commit 6f40c6ed826c from 21 hours
ago (at this time of writing), so it's probably a good
thing this patch hadn't been committed yet.

Although the reason I was keeping an eye on this patch
was for the '4:2:2 and 4:4:4 no longer needing
-strict experimental' part.

> Also, do you need an API bump in configure for this?
>

There's still the question of this, though.  To be
paranoid about making sure the warning on x265's
side doesn't show up, the check could be bumped to
the current version 71, although some/most of the
commits under X265_BUILD 71 do emit that warning for
12-bit.

If it were me, I'd split the 4:2:2/4:4:4 stuff out
into one patch (any API bump for that would have
already been covered by multilib), and then put all
the 12-bit adding in a second patch for whatever
comes of the API bumping discussion.