[FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

[Nicholas Robbins]

On Thursday, August 20, 2015 3:13 PM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
>
>
>On Thu, Aug 20, 2015 at 2:59 PM, Michael Niedermayer
><michael at niedermayer.cc> wrote:
>> On Thu, Aug 20, 2015 at 02:06:18PM -0400, Ganesh Ajjanagadde wrote:
>>> On Thu, Aug 20, 2015 at 1:53 PM, Clément Bœsch <u at pkh.me> wrote:
>>> > On Thu, Aug 20, 2015 at 01:10:43PM -0400, Ganesh Ajjanagadde wrote:
>>> > [...]
>>> >> I know what s is doing, I just fail to see the connection between the name
>>> >> "s" and "filter private context".
>>> >
>>> > s originally stands for struct iirc
>>>
>>> If that is the case, then it is essentially the most uninformative
>>> name one can use.
>>
>>> At least "p" tells us that it is private.
>>
>> if p means private what would be used for public ?
>
>Personally I am not in favor of p,
>as it is still too ambiguous as you rightly point out.
>I instead favor the short abbreviation approach.
>Nevertheless, I still consider this better than s,
>if people have a non negotiable constraint of requiring a single character.


As the original author of the filter. I have absolutely no opinion.

-Nick