[FFmpeg-devel] [PATCH 3/4] fate: add -fflags +bitexact to the relevant targets

[Ronald S. Bultje]

Hi,

On Sat, Aug 22, 2015 at 6:54 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> On Sat, Aug 22, 2015 at 07:57:33PM +0200, Andreas Cadhalpun wrote:
> > This fixes fate with FF_API_LAVF_BITEXACT disabled.
> >
> > Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> > ---
> >  tests/Makefile           |  2 +-
> >  tests/fate-run.sh        | 18 +++++++++---------
> >  tests/fate/mpeg4.mak     |  2 +-
> >  tests/fate/subtitles.mak |  4 ++--
> >  tests/fate/vqf.mak       |  2 +-
> >  5 files changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/tests/Makefile b/tests/Makefile
> > index 06ed011..4791ade 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -48,7 +48,7 @@ tests/data/ffprobe-test.nut: ffmpeg$(EXESUF)
> tests/test_copy.ffmeta
> >       $(M)$(TARGET_EXEC) $(TARGET_PATH)/$< \
> >          -f lavfi -i "aevalsrc=sin(400*PI*2*t):d=0.125[out0];
> testsrc=d=0.125[out1]; testsrc=s=100x100:d=0.125[out2]" \
> >          -f ffmetadata -i $(TARGET_PATH)/tests/test_copy.ffmeta \
> > -        -flags +bitexact -map 0:0 -map 0:1 -map 0:2 -map_metadata 1 \
> > +        -flags +bitexact -fflags +bitexact -map 0:0 -map 0:1 -map 0:2
> -map_metadata 1 \
> >          -map_metadata:s:0 1:s:0 -map_metadata:s:1 1:s:1 \
> >          -vcodec rawvideo -acodec pcm_s16le \
> >          -y $(TARGET_PATH)/$@ 2>/dev/null
> > diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> > index 7aa5df2..c55609d 100755
> > --- a/tests/fate-run.sh
> > +++ b/tests/fate-run.sh
> > @@ -102,11 +102,11 @@ ffmpeg(){
> >  }
> >
> >  framecrc(){
> > -    ffmpeg "$@" -flags +bitexact -f framecrc -
> > +    ffmpeg "$@" -flags +bitexact -fflags +bitexact -f framecrc -
> >  }
>
> is it wanted to basically require specifying the bitexact flag twice
> to get bitexact output ?
>
> is this an improvment of the command line options ?


It is an improvement to the AVFormatContext/AVCodecContext options.

If you want to improve commandline options, maybe introduce a -bitexact
option for ffmpeg_opt.c? You could make it apply to sws/swr also at the
same time. But that does not belong in AVOptions.

Ronald