[FFmpeg-devel] [PATCH 2/3] avformat/hls: comment out unused function

[Ganesh Ajjanagadde]

On Sun, Aug 23, 2015 at 2:01 PM, wm4 <nfxjfg at googlemail.com> wrote:
> On Sat, 22 Aug 2015 22:48:39 -0400
> Ganesh Ajjanagadde <gajjanagadde at gmail.com> wrote:
>
>> On Thu, Aug 20, 2015 at 7:27 PM, Ganesh Ajjanagadde
>> <gajjanagadde at gmail.com> wrote:
>> > Fixes -Wunused-function from
>> > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1
>> >
>> > Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> > ---
>> >  libavformat/hls.c | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/libavformat/hls.c b/libavformat/hls.c
>> > index 82dd744..8a83e40 100644
>> > --- a/libavformat/hls.c
>> > +++ b/libavformat/hls.c
>> > @@ -495,6 +495,7 @@ static int ensure_playlist(HLSContext *c, struct playlist **pls, const char *url
>> >      return 0;
>> >  }
>> >
>> > +/* unused
>> >  static int open_in(HLSContext *c, AVIOContext **in, const char *url)
>> >  {
>> >      AVDictionary *tmp = NULL;
>> > @@ -506,7 +507,7 @@ static int open_in(HLSContext *c, AVIOContext **in, const char *url)
>> >
>> >      av_dict_free(&tmp);
>> >      return ret;
>> > -}
>> > +} */
>> >
>> >  static int url_connect(struct playlist *pls, AVDictionary *opts, AVDictionary *opts2)
>> >  {
>> > --
>> > 2.5.0
>> >
>>
>> ping, just making sure this was not missed.
>
> Why comment it instead of removing it?

It is a non-obvious function that may be used later
(see the #if 1 and #endif in the same file),
and it is easier to read the source than a git log.
See recent patches I sent out, I left most things commented out
instead of deleting them
due to similar reasoning.
I could remove it if that is what people want, and personally don't
care either way.
If we are going with the delete, then we are prioritizing "clean code",
in which case I would remove the #if 1 business as well.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel