[FFmpeg-devel] [PATCH] configure: do not fork off grep subprocess while testing for whitespace

Ganesh Ajjanagadde gajjanagadde at gmail.com
Wed Aug 26 05:22:49 CEST 2015


grep is not necessary for the functionality.
This avoids an unnecessary fork.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
---
 configure | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index db94c45..7acb2dd 100755
--- a/configure
+++ b/configure
@@ -2974,8 +2974,9 @@ if test -f configure; then
     source_path=.
 else
     source_path=$(cd $(dirname "$0"); pwd)
-    echo "$source_path" | grep -q '[[:blank:]]' &&
-        die "Out of tree builds are impossible with whitespace in source path."
+    case "$source_path" in
+        *[[:blank:]]*) die "Out of tree builds are impossible with whitespace in source path." ;;
+    esac
     test -e "$source_path/config.h" &&
         die "Out of tree builds are impossible with config.h in source dir."
 fi
-- 
2.5.0



More information about the ffmpeg-devel mailing list