[FFmpeg-devel] [PATCH] avutil/threadmessage: fix condition broadcasting

Nicolas George george at nsup.org
Tue Dec 1 17:03:42 CET 2015

Le primidi 11 frimaire, an CCXXIV, Clement Boesch a écrit :
> The fix is simply to make sure to notify everyone when work is done (be
> it reading or writing). Another solution would be to use 2 distincts
> conditions.

Another solution would be to document that this API does not support
interleaving messages from several threads (nor to, actually).

I am fine with either solution, with a slight preference with using two
conditions (less spurious wakeups) but it can come later. Your current patch
seems fine.

Thanks for explaining. I guess I had not thought of several simultaneous
writers when convincing myself that a single condition was enough.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151201/5e229b08/attachment.sig>

More information about the ffmpeg-devel mailing list