[FFmpeg-devel] [PATCH v2 11/13] Remove the MIPS "generic" core in favor of "*"
Vicente Olivert Riera
Vincent.Riera at imgtec.com
Wed Dec 2 15:54:06 CET 2015
Dear Andreas Cadhalpun,
On 20/11/15 20:10, Andreas Cadhalpun wrote:
> On 18.11.2015 12:13, Vicente Olivert Riera wrote:
>> There is no point to have a "generic" core when we can catch all
>> unsupported cores with the "*" option, so remove it.
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
>> Changes v1 -> v2:
>> - Nothing.
>> configure | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>> diff --git a/configure b/configure
>> index fc3d559..7d87e5c 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4154,10 +4154,6 @@ elif enabled mips; then
>> - generic)
>> - disable mips64r6
>> - disable msa
>> - ;;
>> disable mipsfpu
>> disable mips32r2
> This is a bad idea.
> If the cpu is not explicitly set via configure options, it is set to generic.
> Removing this generic case here, will force-disable all mips optimizations,
> even if they were explicitly enabled with configure options.
> That would e.g. break how the Debian ffmpeg package is built for mips64el.
Aha, I see.
But I don't understand why msa is disabled for a generic cpu and not the
dsp or dspr2. Either we disable everything, or nothing. But just
disabling features randomly doesn't make any sense, at least for me.
What about this?
# We don't disable anything. Is up to the user to
# disable the unwanted features.
# Unknown CPU. Disable everything.
> Best regards,
More information about the ffmpeg-devel