[FFmpeg-devel] [PATCH 2/2] avcodec: implement vp9 dxva2 hwaccel
h.leppkes at gmail.com
Sat Dec 5 09:36:24 CET 2015
On Fri, Dec 4, 2015 at 3:24 PM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> On Fri, Dec 4, 2015 at 2:55 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> On Thu, Dec 3, 2015 at 5:13 AM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
>>> + /* Create an annex B bitstream buffer with only slice NAL and
>>> finalize slice */
>> What does this comment mean? I suppose it's copy-pasted from someplace else
>> and doesn't really belong here?
>> I can't really review the changes themselves, it's fairly HW specific, so
>> I'd say it's probably OK but I'm probably also not the right person to
>> review it :).
> Oh yeah that comment is copied, should just get rid of it since its
> not even accurate, the VP9 bitstream buffer contains everything,
> including frame headers and whatnot, while for h264 its only slices.
Last call for anyone to review it. History has shown that reviews for
dxva2 patches are hard to come by, but since I'm the maintainer of
these things, either speak up now or it'll just get pushed. :)
More information about the ffmpeg-devel