[FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter
u at pkh.me
Sat Dec 5 12:20:33 CET 2015
On Sat, Dec 05, 2015 at 06:20:29AM +0000, Paul B Mahol wrote:
> Yes, it was and still is wasted time, to find out that there is no
> leaking at all.
There is an allocation, so it could fail under certain context/system
conditions. There is also branching in that code assuming it could fail,
so we have to assume it can happen (or consider it will never and drop
many allocation checks altogether). This branching is broken as
demonstrated by Ganesh (because if it is triggered, it will crash). So
while in practice this is not that important (because this allocation is
unlikely to happen), there is indeed a bug that need to be addressed.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 473 bytes
Desc: not available
More information about the ffmpeg-devel