[FFmpeg-devel] [PATCHv2] avcodec/aacsbr_tablegen: always initialize tables at runtime

Ganesh Ajjanagadde gajjanag at mit.edu
Wed Dec 9 13:39:42 CET 2015


On Wed, Dec 9, 2015 at 5:30 AM, Rostislav Pehlivanov
<atomnuker at gmail.com> wrote:
> On Sat, 2015-12-05 at 14:48 -0500, Ganesh Ajjanagadde wrote:
>>  libavcodec/Makefile                 |  8 ++------
>>  libavcodec/aacsbr_fixed_tablegen.c  | 39 -------------------------
>> ------------
>>  libavcodec/aacsbr_fixed_tablegen.h  |  4 ----
>>  libavcodec/aacsbr_tablegen.c        | 39 -------------------------
>> ------------
>>  libavcodec/aacsbr_tablegen.h        |  4 ----
>>  libavcodec/aacsbr_tablegen_common.h |  4 ----
>>  6 files changed, 2 insertions(+), 96 deletions(-)
>>  delete mode 100644 libavcodec/aacsbr_fixed_tablegen.c
>>  delete mode 100644 libavcodec/aacsbr_tablegen.c
>
> LGTM, sorry for the delay
>
> Another option would be moving everything from aacsbr_tablegen_common.h
> to aacsbrdata.h but that file is big enough as it is and contains only
> tables. So in this case it's IMO better to just
> let aacsbr_tablegen_common.h handle the SBR table generating.

pushed, thanks

>
> Thanks
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


More information about the ffmpeg-devel mailing list