[FFmpeg-devel] [PATCH]lavf/matroskadec: Set codec_tag also for audio codecs

[Michael Niedermayer]

On Thu, Dec 10, 2015 at 11:50:45PM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch is definitely a good idea imo, the mov demuxer also 
> sets codec_tag reading the same atom, for "A_MS/ACM" codec_tag is 
> already set.
> 
> Please comment, Carl Eugen

>  matroskadec.c |    1 +
>  1 file changed, 1 insertion(+)
> 2304ec17547647dad8121a55cac95f099a8e6ef1  patchmkvaudiofourcc.diff
> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index aad567a..95cebdd 100644
> --- a/libavformat/matroskadec.c
> +++ b/libavformat/matroskadec.c
> @@ -2124,6 +2124,7 @@ static int matroska_parse_tracks(AVFormatContext *s)
>              }
>          } else if (track->type == MATROSKA_TRACK_TYPE_AUDIO) {
>              st->codec->codec_type  = AVMEDIA_TYPE_AUDIO;
> +            st->codec->codec_tag   = fourcc;
>              st->codec->sample_rate = track->audio.out_samplerate;
>              st->codec->channels    = track->audio.channels;
>              if (!st->codec->bits_per_coded_sample)

this changes things like:
 Stream #0:7(jpn): Audio: adpcm_ima_wav ([17][0][0][0] / 0x0011), 11025 Hz, 2 channels, s16p, 88 kb/s
to
 Stream #0:7(jpn): Audio: adpcm_ima_wav, 11025 Hz, 2 channels, s16p, 88 kb/s

in [CCCP]_Mega_Weird_Audio_Test.mkv

is that intended ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151211/41b7c8f5/attachment.sig>