[FFmpeg-devel] [PATCH 3/3] avcodec/aacsbr_template: Add Check to read_sbr_envelope()

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Fri Dec 11 17:23:58 CET 2015

On 19.11.2015 14:17, Michael Niedermayer wrote:
> From: Michael Niedermayer <michael at niedermayer.cc>
> The limit is a conservative guess, the spec does not seem to specify a limit
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/aacsbr_template.c |   41 +++++++++++++++++++++++++++++++++--------
>  1 file changed, 33 insertions(+), 8 deletions(-)

This fixes the remaining crash problem in the aac_fixed decoder, which is caused
by underflow of sbr->gain[e][m] in sbr_gain_calc.
(That is the same problem as was caused by calling sbr_dequant twice,
just with a different cause.)

Therefore this patch looks good to me. Thanks!

Best regards,

More information about the ffmpeg-devel mailing list