[FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

Mats Peterson matsp888 at yahoo.com
Mon Dec 14 06:32:22 CET 2015

On 12/14/2015 03:40 AM, Carl Eugen Hoyos wrote:
> Hi!
> Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for me.
> I can't see how duplicating the code from mov.c could be acceptable.
> Please comment, Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

If you look at the patch I've made, it's not DUPLICATING the code, it 
BORROWS some of code for the loops, but they are modified as well, if 
you look closely, and it uses the PRIVATE DATA instead of calling some 
superfluous stsd atom parsing function that reads from the file. I hope 
Michael Niedermayer understands this better than you do, at least.


Mats Peterson

More information about the ffmpeg-devel mailing list