[FFmpeg-devel] [PATCH] ffm: reject a negative codec_id

Michael Niedermayer michaelni at gmx.at
Tue Dec 15 00:43:10 CET 2015

On Tue, Dec 15, 2015 at 12:03:22AM +0100, Andreas Cadhalpun wrote:
> A negative codec_id cannot be handled by the found_decoder API of
> AVStream->info: if the codec_id is not recognized, found_decoder is set
> to -codec_id, which has to be '<0' according to the API documentation.
> This can cause NULL pointer dereferencing in try_decode_frame.
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  libavformat/ffmdec.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

can avcodec_descriptor_get() be used instead of < 0 to check the codec
ids validity ?

codec_type could be checked too that way

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151215/74aeab16/attachment.sig>

More information about the ffmpeg-devel mailing list