[FFmpeg-devel] [libav-devel] [PATCH] nuv: reject negative fps rate

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Thu Dec 17 23:01:29 CET 2015


On 16.12.2015 22:18, Luca Barbato wrote:
> On 16/12/15 20:56, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libavformat/nuv.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/libavformat/nuv.c b/libavformat/nuv.c
>> index 2a1b70f..4cb28d5 100644
>> --- a/libavformat/nuv.c
>> +++ b/libavformat/nuv.c
>> @@ -172,6 +172,10 @@ static int nuv_header(AVFormatContext *s)
>>      if (aspect > 0.9999 && aspect < 1.0001)
>>          aspect = 4.0 / 3.0;
>>      fps = av_int2double(avio_rl64(pb));
>> +    if (fps <= 0.0f) {
>> +        av_log(s, AV_LOG_ERROR, "Invalid frame rate %f\n", fps);
>> +        return AVERROR_INVALIDDATA;
>> +    }
>>  
>>      // number of packets per stream type, -1 means unknown, e.g. streaming
>>      v_packs = avio_rl32(pb);
>>
> 
> What happens if a negative fps is used?

It doesn't make sense. Or what is a negative frame rate supposed to mean?

Also it triggers an av_assert2 in FFmpeg's av_rescale_rnd.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list