[FFmpeg-devel] support for reading / writing encrypted MP4 files

Eran Kornblau eran.kornblau at kaltura.com
Tue Dec 22 08:36:41 CET 2015

> > You're right, didn't know that.
> > Please let me know if there are any changes you want me to apply in order to push the third one (decryption support).
> sounds like you missed:
> http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/185235.html
> http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/185238.html
Correct, I missed it. It's just that I'm not getting any emails from this mailing list 
(verified they are not getting to the junk folder...). 
So I've been polling the page of the last message of this thread in ffmpeg.org,
and guess these posts were added to a different leaf of the message tree...
Would really appreciate it if this could be resolved, either add my work email -
eran dot kornblau at kaltura dot com or my personal email - 
erankor at gmail dot com.

> if you want to maintain the code in the future then please send a
> patch that adds you to the maintainers file
> > +    id = mov_codec_id(st, format);
> > +    st->codec->codec_id = id;
> doesnt this allow changing the codec id to anything from anything ?
> this seems potentially risky
I see options to address this:
1. overwrite the codec_id only when it's AV_CODEC_ID_NONE
2. (stricter) save the format 4cc (that is loaded in ff_mov_read_stsd_entries) to some member of 
MOVStreamContext, and overwrite the codec id only when the format is 'encv' or 'enca'

please let me know which one you prefer, and I will update the patch.

> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Thanks a lot, Michael !

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-Eran-Kornblau-to-maintainers.patch
Type: application/octet-stream
Size: 1184 bytes
Desc: 0001-add-Eran-Kornblau-to-maintainers.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151222/829b2b42/attachment.obj>

More information about the ffmpeg-devel mailing list