[FFmpeg-devel] [PATCH] libavformat: palettized QuickTime in Matroska, round 2

[Michael Niedermayer]

On Tue, Dec 22, 2015 at 03:55:48AM +0100, Mats Peterson wrote:
> Alright, this is take two of my fix for palettized QuickTime video
> in Matroska. I have reset the lower limit of V_QUICKTIME private
> data to 21 in matroskadec.c, in order to make that broken file pass,
> Michael. The minimum size of a video sample description in QuickTime
> is really 86, for the record.
> 
> Also, I've added copyright notices of the former authors of mov.c to
> the new file qtpalette.c, since the code in that file is borrowed
> from mov.c to a major extent, albeit with some modifications.
> 
> Original explanation of the patch follows:
> 
> Palettized QuickTime video in Matroska has hitherto not been
> recognized whatsoever, and the "palette" used has been completely
> random.
> 
> The patch for matroskadec.c fixes this issue by adding a palette
> side data packet in matroska_deliver_packet(), much in the same way
> as it's done in mov.c.
> 
> The change to mov.c consists mainly of moving the palette handling
> from the mov_parse_stsd_video() function to a new get_qtpalette()
> function in the new file qtpalette.c, which is shared by both
> matroskadec.c and mov.c.
> 
> In matroskadec.c, I'm also putting the palette in 'extradata', like
> it's done for V_MS/VFW/FOURCC; this is a requirement in order for
> MPlayer to recognize the palette.
> 
> -- 
> Mats Peterson
> http://matsp888.no-ip.org/~mats/

[...]

> +int get_qtpalette(int codec_id, uint8_t *stsd, uint32_t *palette)

non static functions need a prefix (ff_ in this case)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151222/57bd6e5f/attachment.sig>