[FFmpeg-devel] [PATCH] palettized QuickTime video in Matroska, round 3

Mats Peterson matsp888 at yahoo.com
Tue Dec 22 22:01:16 CET 2015

On 12/22/2015 09:50 PM, Mats Peterson wrote:
> OK, Michael (among others), I have changed the name from get_qtpalette()
> to ff_get_qtpalette(). I've also added a *pb (AVIOContext) parameter to
> the ff_get_qtpalette() function, since one has to consume the full
> sample description when called from mov.c. This wasn't done before. In
> matroskadec.c, the sample description is already in the in-memory
> private data. It's beginning to get a bit kludgy, but I still think it's
> nice with a common palette handling function that is shared by both
> matroskadec.c and mov.c.
> Original description of issue follows:
> Palettized QuickTime video in Matroska has hitherto not been recognized
> whatsoever, and the "palette" used has been completely random.
> The patch for matroskadec.c fixes this issue by adding a palette side
> data packet in matroska_deliver_packet(), much in the same way as it's
> done in mov.c.
> The change to mov.c consists mainly of moving the palette handling from
> the mov_parse_stsd_video() function to a new get_qtpalette() function in
> the new file qtpalette.c, which is shared by both matroskadec.c and mov.c.
> In matroskadec.c, I'm also putting the palette in 'extradata', like it's
> done for V_MS/VFW/FOURCC; this is a requirement in order for MPlayer to
> recognize the palette.

Forgot to remove a fprintf() line in mov.c. New patch attached.

Mats Peterson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libavformat-palettized-QuickTime-video-in-Matroska-r.patch
Type: text/x-patch
Size: 14280 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151222/ed4d118d/attachment.bin>

More information about the ffmpeg-devel mailing list