[FFmpeg-devel] [PATCH] Adding frame side data about green metadata

[Vittorio Giovara]

On Wed, Dec 23, 2015 at 12:28 PM, Nicolas Derouineau
<nicolas.derouineau at vitec.com> wrote:
> Hello,
> Please find here enclosed a patch adding frame side data information about green metadata.

The logic is ok, but the introduction of av_greenmetadata_set is a
no-go for me. This function is exposed to every user (with a non-fixed
data type) and its only purpose is to set the values in an array.
There is no need for that: if you believe that there are going to be
many codecs needing this functionality, just add a private function in
a separate file within libavcodec, otherwise you may initialize the
array directly in the sei_green_metadata_present check in h264.c
without any function call at all.

As a minor nit, please keep the code style consistent, with spaces
around '=', 'if's and logic operators.
-- 
Vittorio