[FFmpeg-devel] [PATCH 3/3] lavu/internal: tighten errors for avpriv_exp10

Ganesh Ajjanagadde gajjanag at mit.edu
Sun Dec 27 00:10:43 CET 2015


On Sat, Dec 26, 2015 at 2:44 PM, Nicolas George <george at nsup.org> wrote:
> Le sextidi 6 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit :
>> Point taken though: the only clear changes are ones which are Pareto
>> improvements for speed and accuracy
>
> ... AND code complexity. For example, the pow(10, x) call in testsrc is
> neither speed-critical nor accuracy-critical.

Of course. What I referred to were relatively objective metrics. Code
complexity is inherently subjective, and what constitutes complexity
varies a lot based on individual tastes.

And there is also the question of internal vs external complexity, for
instance, this patch only increases internal complexity of ff_exp10,
but not external complexity for clients of ff_exp10. This is also
subjective.

>
> Regards,
>
> --
>   Nicolas George
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list