[FFmpeg-devel] [PATCH] AAC encoder: fix assertion error with prediction

Rostislav Pehlivanov atomnuker at gmail.com
Tue Dec 29 10:18:45 CET 2015

Wouldn't it be simpler to just check if the maximum codebook was 0 after
calculating cost1 and skipping the rest of the code in the loop?

On 29 December 2015 at 08:23, Claudio Freire <klaussfreire at gmail.com> wrote:

> Fixes an assertion error reported in #2686 that happens when
> using prediction (either explicitly or implicitly by setting
> the AAC main profile), since prediction code would allow
> creating new zeroes or removing existing ones, without
> properly checking for SF delta violations.
> This patch forbids creating/removing zeroes, perhaps an
> overly conservative approach, but a safe one. More permissive
> and sophisticated approaches may be attempted in the future.
> Attached
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

More information about the ffmpeg-devel mailing list