[FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

[Mats Peterson]

On 12/29/2015 06:42 PM, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michael <at> niedermayer.cc> writes:
>
>> On Tue, Dec 29, 2015 at 04:56:26PM +0000, Carl Eugen Hoyos wrote:
>>> Michael Niedermayer <michael <at> niedermayer.cc> writes:
>>>
>>>>> https://drive.google.com/open?id=0B3_pEBoLs0faUlItWm9KaGJSTEE
>>>>
>>>> patch applied
>>>
>>> How exactly did you test this?
>>
>> it is neccessary to also fix the decoder to test
>
> (I disagree.)
> If that were true, more time should be given for
> reviews imo.
>
>> this was a fix for just the demuxer side
>
> If you cannot test, how do you know it is correct?
>
> The palette is transparent, this indicates a bug
> somewhere afaict (not necessarily in the demuxer.)
> The palette is never used because gray is signaled,
> this indicates another difficult to understand
> issue, this one definitely demuxer-related.
> In any case, the patch is not a sufficient fix for
> the demuxer issue.
>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

There is no "bug" or "demuxer issue", Carl. The problem lies entirely on 
the decoder side, and the fact that qtrle for 1-bit video uses 
AV_PIX_FMT_MONOWHITE rather than AV_PIX_FMT_PAL8, like Michael mentioned 
before. I just got it working properly in the decoder by the way. I'll 
be back.

Mats

-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/