[FFmpeg-devel] [PATCH] oggparsedaala: reject too large gpshift

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Wed Dec 30 01:00:43 CET 2015

On 29.12.2015 22:27, Rostislav Pehlivanov wrote:
> oggparsetheora has the same bit of code to read the gpshift, so it would
> probably be a good idea to add it to this patch as well.

No, oggparsetheora only reads 5 bits for gpshift.
The only thing from this patch that also applies there is the (theoretical)
issue of 1<<31 not being defined for int32_t.

On 29.12.2015 22:32, Hendrik Leppkes wrote:
> 1U << hdr->gpshift?

Sure. Updated patch attached.

Best regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-oggparsedaala-reject-too-large-gpshift.patch
Type: text/x-diff
Size: 1900 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151230/a8af10ee/attachment.patch>

More information about the ffmpeg-devel mailing list