[FFmpeg-devel] [PATCH 1/7] opt: Remove dead code

[Timothy Gu]

On Fri Feb 06 2015 at 1:28:09 AM Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Timothy Gu <timothygu99 <at> gmail.com> writes:
>
> >          if (!i || !*val)
> >              return 0;
> >      }
> > -
> > -    return 0;
> >  }
>
>

> I fear that some (broken) compilers will emit
> a warning when this gets applied that we
> request to be interpreted as an error.
> Same for 3, 4 and 5.
>

Do you want to remove some warnings from some good compilers, or from some
dumb compilers? I'd go with the first.


> I don't remember if an assert helps.
>

Probably not. The assert will still be dead code, and the compiler still
warns.

Timothy