[FFmpeg-devel] [PATCH 2/3] avutil: check pixdescs in a different place

Michael Niedermayer michaelni at gmx.at
Tue Feb 10 15:57:35 CET 2015


On Tue, Feb 10, 2015 at 01:27:03PM +0100, wm4 wrote:
> Doing this check in avutil_version() is not appropriate. Also, this code
> is by default disabled (--assert-level is by default 0). A FATE run with
> defaults will never execute the checks.
> 
> Move it to the pixelutils test program. Whatever reason there was in
> avutil_version() not to run this test by default, it should be fine in
> this test program. This means FATE will run the test by default. (Yes,
> pixelutils is not strictly the best place for it either, but it's
> better.)
> 
> (pixdesc.c also has a small test program, but it's never run by FATE.)
> ---
>  libavutil/pixelutils.c | 3 +++
>  libavutil/utils.c      | 3 ---
>  2 files changed, 3 insertions(+), 3 deletions(-)

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150210/a8a387f4/attachment.asc>


More information about the ffmpeg-devel mailing list