[FFmpeg-devel] libavutil: optimize camellia cipher

Michael Niedermayer michaelni at gmx.at
Tue Feb 10 17:33:17 CET 2015


On Tue, Feb 10, 2015 at 09:31:24PM +0530, supraja reddy wrote:
> Hello,
> 
> > +    AV_WB64(y,KE);
> > > +
> > KE=SP[0][y[0]]^SP[1][y[1]]^SP[2][y[2]]^SP[3][y[3]]^SP[4][y[4]]^SP[5][y[5]]^SP[6][y[6]]^SP[7][y[7]];
> > > +    return KE;
> >
> > have you tried it without the y[] array ?
> > storing and loading from memory may (or may not) be slower
> 
> 
> I have tried without y[] array. And there seems to be some improvement in
> the time.
> 
> lavu       CAMELLIA     size: 1048576  runs:   1024  time:   21.549 +- 0.176
> 
> I have attached a patch with the respective changes. Would you want me to
> convert the F() into a macro ?

if its faster, please change it to a macro, otherwise do as you
prefer

patch applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150210/b65d1564/attachment.asc>


More information about the ffmpeg-devel mailing list