[FFmpeg-devel] [PATCH] avformat: Add simple ACLR atom reading to set the color range

[Michael Niedermayer]

On Tue, Feb 17, 2015 at 09:20:23AM +0000, Kevin Wheatley wrote:
>  Add simple ACLR atom reading to set the color range of the incomming
>  track for codec's like DNxHD that utilise AVID's proprietary atom.
> 
> Note: for this to work with ffmpeg generated DNxHD QuickTime files you
> need to also use my other patch to prevent ffmpeg generating 'corrupt'
> files.

>  mov.c |   32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
> 5ac7eb280035947f002b850cca2049a31a663e45  0001-Add-simple-ACLR-atom-reading-to-set-the-color-range-.patch
> From 561db6b347bed1f60131c3eb2bebe890a402ad63 Mon Sep 17 00:00:00 2001
> From: Kevin Wheatley <kevin.j.wheatley at gmail.com>
> Date: Tue, 17 Feb 2015 09:15:06 +0000
> Subject: [PATCH] Add simple ACLR atom reading to set the color range of the incomming
>  track for codec's like DNxHD that utilise AVID's proprietary atom.
> 
> 
> Signed-off-by: Kevin Wheatley <kevin.j.wheatley at gmail.com>
> ---
>  libavformat/mov.c |   32 +++++++++++++++++++++++++++++++-
>  1 files changed, 31 insertions(+), 1 deletions(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 6d2262a..0d4b0cf 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -1178,6 +1178,36 @@ static int mov_read_ares(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>      return mov_read_avid(c, pb, atom);
>  }
>  
> +static int mov_read_aclr(MOVContext *c, AVIOContext *pb, MOVAtom atom)
> +{
> +    int ret = mov_read_avid(c, pb, atom);
> +
> +    if (!ret && c->fc->nb_streams >= 1) {
> +        if (atom.size == 16) {
> +            AVCodecContext *codec = c->fc->streams[c->fc->nb_streams-1]->codec;
> +            
> +            /* This assumes the atom will be at the end of the extradata */
> +            const uint8_t range_value = codec->extradata[codec->extradata_size - 5];

this is missing a check on extradata_size being large enough

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150217/2c74cddc/attachment.asc>