[FFmpeg-devel] [PATCH] avformat: Add simple ACLR atom reading to set the color range
michaelni at gmx.at
Tue Feb 17 16:28:11 CET 2015
On Tue, Feb 17, 2015 at 12:40:52PM +0000, Kevin Wheatley wrote:
> On Tue, Feb 17, 2015 at 12:25 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > if the codec id doesnt match the expected, mov_read_extradata will
> > return 0 even without any truncation.
> > In this case the error message would be incorrect
> So should I code the test against codec id against the files I have or
> the ones that might be valid, but I don't have samples for?
> It looks like AV_CODEC_ID_AVUI and AV_CODEC_ID_DNXHD are tested for in
> other parts of the code, so I'd be comfortable with those. However I'm
> thinking the call to mov_read_avid might be skipped/inlined if I only
> tested against the DNxHD codec, there is something that begins to look
> like a code smell if I duplicate the list of codecs, but I'm happy to
> go with whatever is preferred.
the problem is that this code is tied to extradata
and we only copy this atom into extradata for AVUI and DNXHD, for
other codecs we dont so this information is lost for them
I think the atom should be interpreted independant of the codec id
because, why not, if the mov file says its color_range is X why should
that be ignored for other codecs
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel