[FFmpeg-devel] [PATCH] avformat/hlsenc: Warn if a non file protocol is used

Michael Niedermayer michaelni at gmx.at
Sat Feb 21 19:29:23 CET 2015


Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
---
 libavformat/hlsenc.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index bf79109..7885351 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -247,6 +247,10 @@ static int hls_window(AVFormatContext *s, int last)
     int version = hls->flags & HLS_SINGLE_FILE ? 4 : 3;
     const char *proto = avio_find_protocol_name(s->filename);
     int use_rename = proto && !strcmp(proto, "file");
+    static unsigned warned_non_file;
+
+    if (!use_rename && !warned_non_file++)
+        av_log(s, AV_LOG_ERROR, "Cannot use rename on non file protocol, this may lead to races and temporarly partial files\n");
 
     snprintf(temp_filename, sizeof(temp_filename), use_rename ? "%s.tmp" : "%s", s->filename);
     if ((ret = avio_open2(&out, temp_filename, AVIO_FLAG_WRITE,
-- 
1.7.9.5



More information about the ffmpeg-devel mailing list