[FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

Michael Niedermayer michaelni at gmx.at
Thu Feb 26 18:15:30 CET 2015

On Thu, Feb 26, 2015 at 04:54:02PM +0100, Clément Bœsch wrote:
> On Thu, Feb 26, 2015 at 01:53:13PM +0000, Derek Buitenhuis wrote:
> > On 2/26/2015 1:50 PM, Clément Bœsch wrote:
> > > If the option is set by default, you don't want to warn for no reason.
> > 
> > It's not set by default. That patch never went in.
> > 
> Ah, my bad.
> > I don't believe silently not writing it is a valid approach. Then
> > again I think setting a default movflag like that instead of
> > changing the option is also stupid.
> Well, breaking API on purpose when easily avoidable is kind of stupid too.
> You can also just deprecate the current flag and add yours. The point is
> to not make the option disappear because it will break callers. Changing
> the behaviour (enabling by default / making the old option void) is fine,
> breaking the API (removing the option) not so much.

the option is in there since a month and was in no release so
IMHO if people feel strongly about it then i guess simply replacing
the option might be acceptable
Strictly correct though it is to deprecate it and make it point
to the new option though help text and or warning

random idea:
the new option could be a int with 3 states, on/force, off, auto
where auto would write it only for supported formats like mov and
maybe mp4


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150226/78c5ed46/attachment.asc>

More information about the ffmpeg-devel mailing list