[FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

[Michael Niedermayer]

On Fri, Jan 09, 2015 at 12:08:21PM +0530, arwa arif wrote:
> On Fri, Jan 9, 2015 at 12:27 AM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> > On Thu, Jan 08, 2015 at 04:03:18PM +0100, Michael Niedermayer wrote:
> > > On Thu, Jan 08, 2015 at 07:32:51PM +0530, arwa arif wrote:
> > > > On Thu, Jan 8, 2015 at 7:23 PM, Michael Niedermayer <michaelni at gmx.at>
> > > > wrote:
> > > >
> > > > > On Thu, Jan 08, 2015 at 01:43:24PM +0530, arwa arif wrote:
> > > > > > On Wed, Jan 7, 2015 at 9:46 PM, Michael Niedermayer <
> > michaelni at gmx.at>
> > > > > > wrote:
> > > > > >
> > > > > > > On Wed, Jan 07, 2015 at 03:42:16PM +0100, Stefano Sabatini wrote:
> > > > > > > > On date Wednesday 2015-01-07 19:14:49 +0530, arwa arif encoded:
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > Keep in mind that the difference may be due to the QP
> > information
> > > > > > > > > > missing in mp=pp7. So you should focus on that (try to
> > > > > reset/disable
> > > > > > > > > > qp processing in pp7 and see if it works the same as
> > mp=pp7).
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > > > For qp=0, the results are bitexact. I am not able to figure
> > out
> > > > > how do
> > > > > > > I
> > > > > > > > > take care
> > > > > > > >
> > > > > > > > Isn't qp=0 the default? How do you get (with which parameters)
> > mp=pp7
> > > > > > > > and pp7 to issue the same output?
> > > > > > >
> > > > > > > i get the same output for
> > > > > > > mp=pp7=10:0 and  pp7=10:0
> > > > > > > mp=pp7=10:1 and  pp7=10:1
> > > > > > > mp=pp7=10:2 and  pp7=10:2
> > > > > > >
> > > > > > > the default for mode seems to differ though so the mode has to be
> > > > > > > specified for comparing
> > > > > > >
> > > > > > >
> > > > > > But I am getting same ouput for default mode,  i.e,
> > > > > > mp=pp7=0:0 and  pp7=0:0
> > > > > > mp=pp7=0:1 and  pp7=0:1
> > > > > > mp=pp7=0:2 and  pp7=0:2
> > > > > >
> > > > > > When qp is a non-zero value, the output is different.
> > > > >
> > > > > it was the same here, how can i reproduce a case where it differs ?
> > > > > what input did you use ? what command line ?
> > > > >
> > > >
> > > > I compared it for mp=pp7=30 and pp7=30.
> > > > The command line I used was:
> > > > ./ffmpeg -i ../a.png -vf pp7=30 -f md5 ../new
> > > > ./ffmpeg -i ../a.png -vf mp=pp7=30 -f md5 ../old
> > >
> > > as the default mode differs you must specify the mode
> > > like
> > > -vf pp7=30:0
> > > -vf mp=pp7=30:0
> > > or
> > > -vf pp7=30:1
> > > -vf mp=pp7=30:1
> > > or
> > > -vf pp7=30:2
> > > -vf mp=pp7=30:2
> > >
> > > or change the default so it matches
> >
> > ./ffmpeg -v 0 -i matrixbench_mpeg2.mpg -vf mp=pp7=30:1 -t 1 -f md5 -
> > MD5=a96e711815a1006cc3e9faec8e6bee66
> >
> > ./ffmpeg -v 0 -i matrixbench_mpeg2.mpg -vf pp7=30:1 -t 1 -f md5 -
> > MD5=a96e711815a1006cc3e9faec8e6bee66
> >
> >
> They are using mp=pp7=0:0 as default. But, in documentation they have
> mentioned that medium thresholding (mp=pp7=0:2) is default. What should I
> follow?

its probably less confusing to use the same default as the mp=pp7
code does otherwise any default is fine

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150109/45139046/attachment.asc>