[FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

[Kieran Kunhya]

On 17 January 2015 at 23:00, Nicolas George <george at nsup.org> wrote:
> L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit :
>> I don't make the standards and frankly whether you dislike them is
>> your problem but they exist and need to work correctly.
>> Instead you wish to break things based off an artificial test pattern
>> and your own beliefs.
>
> I do not wish to break things, I wish to fix them correctly.
>
> The so-called fix in nvenc is completely wrong, because it happens at the
> wrong place: it introduces exceptional cases, it violates the rules of
> arithmetic, it is not documented, it affects cases that should be left alone
> and misses cases it should handle, it behaved differently than other parts
> of the code. Is it enough, or do you need more reasons?

The behaviour of the Nvidia code I believe is correct.
As far as I understand it corrects SAR for 720-width content to comply
with BT601.

Kieran