[FFmpeg-devel] [PATCH] avfilter: Port mp=softpulldown to lavfi

Kieran Kunhya kierank at obe.tv
Thu Jan 29 10:57:10 CET 2015


On 29 January 2015 at 09:20, Paul B Mahol <onemda at gmail.com> wrote:
> On 1/29/15, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Wed, Jan 28, 2015 at 03:13:27PM +0000, Paul B Mahol wrote:
>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>> ---
>>> Bit-exact with mp=softpulldown except first frame which is uninitialized
>>> data in mp filter.
>>
>>> TODO: pts needs update, workaround is to use setpts filter.
>>
>> patch LGTM except the pts / time_base issue
>
> mp=softpulldown sets all frames to MP_NOPTS_VALUE.
>
> I do not see way how to set filter to use variable frame rate, which
> is possible as repeat_pict can change during stream.

IMO the filter needs to reject a timebase that's not 1001/24000
exactly and it'll need to change the timebase and pts to 1001/30000.
See how x264 does it.

Kieran


More information about the ffmpeg-devel mailing list