[FFmpeg-devel] [FFmpeg-cvslog] Adding Closed caption Support

[Michael Niedermayer]

On Tue, Jan 20, 2015 at 04:39:40PM +0530, Anshul wrote:
> 
> On 01/13/2015 01:15 PM, Clément Bœsch wrote:
> >On Tue, Jan 13, 2015 at 08:12:10AM +0100, Clément Bœsch wrote:
> >>On Tue, Jan 13, 2015 at 11:26:06AM +0530, Anshul Maheshwari wrote:
> >>[...]
> >>>>Also added roll-up functionality.
> >>>>
> >>>>patch is attached.
> >>>>Thanks
> >>>>Anshul
> >>>>
> >>>Attaching patch
> >>> From ca66e917f45bd47dd797930423d488fa9c781c4c Mon Sep 17 00:00:00 2001
> >>>From: Anshul Maheshwari <anshul.ffmpeg at gmail.com>
> >>>Date: Mon, 12 Jan 2015 06:21:18 -0800
> >>>Subject: [PATCH] Addig Rollup functionality
> >>>
> >>>Signed-off-by: Anshul Maheshwari <anshul.ffmpeg at gmail.com>
> >>>---
> >>>  libavcodec/ccaption_dec.c | 222 +++++++++++++++++++++++++++++-----------------
> >>>  1 file changed, 140 insertions(+), 82 deletions(-)
> >>>
> >>Please split your changes.
> >>
> >>One patch for the cosmetics
> >>One patch for the CHAR_DEBUG/av_dlog
> >>One patch for the addition of av_log
> >>One patch for the reflow of init_decoder()
> >>One patch for the roll-up functionality
> >>One patchset to rule them all.
> >>
> >>Thank you.
> >>
> >hint: git add -p is your friend
> >
> >
> Thanks still learning it, most of the time git say patch cant be applied.
> 
> 
> 
> Attached all patch.
> 
> -Anshul

[...]
>  ccaption_dec.c |    2 ++
>  1 file changed, 2 insertions(+)
> 72af7072bc57b3f66911b14cb09b1ed6e74cb125  0004-Adding-color-and-fonts-for-future-use-in-screen.patch
> From 90915dfc6fecb57787b3aad228781ed04f3e7cb9 Mon Sep 17 00:00:00 2001
> From: Anshul Maheshwari <er.anshul.maheshwari at gmail.com>
> Date: Tue, 20 Jan 2015 16:02:29 +0530
> Subject: [PATCH 4/8] Adding color and fonts for future use in screen

applied


[...]

> @@ -426,10 +466,13 @@ static int process_cc608(CCaptionSubContext *ctx, int64_t pts, uint8_t hi, uint8
>          handle_delete_end_of_row(ctx, hi, lo);
>      } else if ( COR3(hi, 0x14, 0x15, 0x1C) && lo == 0x25 ) {
>          ctx->rollup = 2;
> +        ctx->mode = CCMODE_ROLLUP_2;
>      } else if ( COR3(hi, 0x14, 0x15, 0x1C) && lo == 0x26 ) {
>          ctx->rollup = 3;
> +        ctx->mode = CCMODE_ROLLUP_3;
>      } else if ( COR3(hi, 0x14, 0x15, 0x1C) && lo == 0x27 ) {
>          ctx->rollup = 4;
> +        ctx->mode = CCMODE_ROLLUP_3;

is this intended to be CCMODE_ROLLUP_3 instead of CCMODE_ROLLUP_4 ?

also do you have a file to test this and the other patches ?

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150129/0678279d/attachment.asc>