[FFmpeg-devel] [PATCH 2/5] copy stream metadata when using concat

[Nicolas George]

Le tridi 13 messidor, an CCXXIII, Vadim Belov a écrit :
> From: unknown <vadimb at VADIMB-T440.nice.com>

Not good. Please configure Git to include a valid name and address.

> 
> ---
>  libavformat/concatdec.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c
> index f07cfd7..c61d5c2 100644
> --- a/libavformat/concatdec.c
> +++ b/libavformat/concatdec.c
> @@ -172,6 +172,8 @@ static int copy_stream_props(AVStream *st, AVStream *source_st)
>      st->avg_frame_rate      = source_st->avg_frame_rate;
>      st->time_base           = source_st->time_base;
>      st->sample_aspect_ratio = source_st->sample_aspect_ratio;
> +	
> +    av_dict_copy(&st->metadata, source_st->metadata, 0);
>      return 0;
>  }

Code change LGTM if tested.

(I am a bit shocked that av_dict_copy() does not return an error code, but
that is not your fault.)

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150701/08519532/attachment.asc>