[FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not unecessarily consume memory for cuepoints

Michael Niedermayer michaelni at gmx.at
Tue Jul 7 18:45:04 CEST 2015


On Tue, Jul 07, 2015 at 03:13:06PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Matroska streaming currently consumes memory for 
> cuepoints that are never used if the output stream 
> is no seekable. This can lead to oom.
> Attached patch fixes ticket #4690.
> 
> Please comment, Carl Eugen

>  matroskaenc.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 3bf45b1a064962b7e988c3ee5739cc8f2faf023d  patchmkvseekable.diff

breaks fate

--- -   2015-07-07 18:41:50.396915978 +0200
+++ tests/data/fate/wavpack-matroska_mux-mono   2015-07-07 18:41:50.391085872 +0200
@@ -1 +1 @@
-a2987e2e51e01a35e47e7da13eb47a35
+26ad3026d5f8ae54d7e2a5d60ae8888a
Test wavpack-matroska_mux-mono failed. Look at tests/data/fate/wavpack-matroska_mux-mono.err for details.
make: *** [fate-wavpack-matroska_mux-mono] Error 1
make: *** Waiting for unfinished jobs....
--- -   2015-07-07 18:41:50.410691975 +0200
+++ tests/data/fate/wavpack-matroska_mux-61     2015-07-07 18:41:50.407085873 +0200
@@ -1 +1 @@
-ffba4ddea1ba71f7a5901d9ed1a267be
+823ff6a5b7bf1672c5b63f38193e9890
Test wavpack-matroska_mux-61 failed. Look at tests/data/fate/wavpack-matroska_mux-61.err for details.
make: *** [fate-wavpack-matroska_mux-61] Error 1

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150707/9e541fa6/attachment.sig>


More information about the ffmpeg-devel mailing list