[FFmpeg-devel] [PATCH] configure: try to fix \r when build for android on cygwin

[Michael Niedermayer]

On Thu, Jul 09, 2015 at 03:09:49PM +0800, Zhang Rui wrote:
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 5833808..46c4788 100755
> --- a/configure
> +++ b/configure
> @@ -475,7 +475,7 @@ sh_quote(){
>  }
>  
>  cleanws(){
> -    echo "$@" | sed 's/^ *//;s/  */ /g;s/ *$//;s/\\r//g'
> +    echo "$@" | sed "s/^ *//;s/  */ /g;s/ *$//;s/\\r//g"

i think the code before and after the patch is wrong
backslash escapes with sed are not portable


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150710/b1de3694/attachment.sig>