[FFmpeg-devel] [PATCH 1/3] aacdec: move the LTP and TNS tables out of aacdectab.h

[Nedeljko Babic]

>On Mon, Jul 20, 2015 at 8:50 AM, Nedeljko Babic
><Nedeljko.Babic at imgtec.com> wrote:
>>>This commit moves the tables required for encoding and decoding
>>>LTP and TNS AAC files out of the decoder's standalone tables file
>>>and into the shared aactab.h, where they can be used by both the
>>>encoder and the decoder.
>>>
>>>This commit does not break the already-broken aac_fixed decoder.
>>
>> Not sure I would say that it is broken, since it is not implemented fully yet...
>
>I think even with the other patches submitted to the list, TNS (which
>uses lpc) will break. It will be sending an int* to a function that
>takes float* (check lpc.h, vs aacdec_template.c:3223 + aac.h:244)
>

I am failing to see this.

If we are talking about functions defined in lpc.h (compute_ref_coefs and compute_lpc_coefs), they are taking LPC_TYPE and it depends on definition of USE_FIXED.

In case of lpc.h, USE_FIXED is by default set to zero in aac_defines.h included in lpc.h

apply_tns is sending int* to compute_lpc_coefs() only in case of aacdec_fixed (and in that case compute_lpc_coefs() expects int*, not float*).