[FFmpeg-devel] [PATCH 1/2] ffmpeg: reset tty state correctly

wm4 nfxjfg at googlemail.com
Mon Jul 27 13:35:11 CEST 2015


On Mon, 27 Jul 2015 10:39:16 +0200
Nicolas George <george at nsup.org> wrote:


> > +    signal(SIGSEGV, sigterm_handler); /* Segmentation fault (ANSI).     */
> > +    signal(SIGILL , sigterm_handler); /* Invalid instruction (ANSI).    */
> > +    signal(SIGFPE , sigterm_handler); /* Arithmetic error (ANSI).       */
> 
> NO!!!
> 
> When a crash happens, we want it to happen right there, possibly leave a
> core. We do not want a signal handler to mess up the remains.

+1
 
> >  #ifdef SIGXCPU
> >      signal(SIGXCPU, sigterm_handler);
> >  #endif

Why?


More information about the ffmpeg-devel mailing list