[FFmpeg-devel] [PATCH] Reenable GHA phase inversion in Atrac3+

Michael Niedermayer michaelni at gmx.at
Mon Jun 8 02:46:34 CEST 2015


On Mon, Jun 08, 2015 at 02:17:16AM +0200, Max Pole wrote:
> Hello crews,
> 
> I attached two simple patches reenabling a decoder feature been initially
> disabled due to lack of real-world samples.
> 

> I've recently got a couple of appropriate samples from the PPSSPP emulator
> project so I coud test this feature extensively.

where can i find these samples ?
are they online somewhere? can you upload them ?


> 
> The 2nd patch is a cosmetical one that renames the "phase_shift" variable
> to "inverse_phase". This seems to give a better description of what's
> actually going on (180° phase shift).
> 

> Do we need to update FATE tests to include a test for this feature?

a fate test  might be interresting if its possible/reliable and
not too hard to implement

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150608/9cc1a2a2/attachment.asc>


More information about the ffmpeg-devel mailing list