[FFmpeg-devel] [PATCH] configure: enable VSX for ppc64el

Michael Niedermayer michaelni at gmx.at
Sat Jun 13 20:26:19 CEST 2015


On Sat, Jun 13, 2015 at 01:15:46PM +0200, Andreas Cadhalpun wrote:
> On 13.06.2015 02:12, Michael Niedermayer wrote:
> > On Fri, Jun 12, 2015 at 08:40:28PM +0200, Andreas Cadhalpun wrote:
> >> Together with commit 04f0002 this changes the behavior back to what it
> >> was was before commit b0af404.
> >>
> >> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> >> ---
> >>  configure | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/configure b/configure
> >> index 0c907ff..3a6af6e 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -4610,6 +4610,9 @@ unsigned int endian = 'B' << 24 | 'I' << 16 | 'G' << 8 | 'E';
> >>  EOF
> >>  od -t x1 $TMPO | grep -q '42 *49 *47 *45' && enable bigendian
> >>  
> >> +if enabled ppc64 && ! enabled bigendian && enabled altivec; then
> >> +    enable vsx
> >> +fi
> >>  
> > 
> > this breaks --disable-vsx
> 
> Yes and commit 04f0002 broke --enable-vsx for generic cpu.
> Attached patch fixes that.
> 
> Best regards,
> Andreas

>  configure |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> dc2fb04d40cd6ace77c2977ab02ec349d5fe5791  0001-configure-only-disable-VSX-for-ppc64el.patch
> From 205b42daffe112ef83b6f3c297707e556c97300f Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Sat, 13 Jun 2015 13:09:21 +0200
> Subject: [PATCH] configure: only disable VSX for !ppc64el
> 
> This reverts commit 04f0002, which made it impossible to enable VSX with
> a generic cpu.
> 
> This changes the behavior back to what it was before commit b0af404.

LGTM

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150613/88685c9d/attachment.asc>


More information about the ffmpeg-devel mailing list