[FFmpeg-devel] GSoC Weekly Report (libswscale refactor)

[wm4]

On Thu, 25 Jun 2015 13:34:57 -0300
Pedro Arthur <bygrandao at gmail.com> wrote:

> > it passes fate but seems to crash for example with:
> > ./ffmpeg -i lena.pnm  -vf format=gbrp test.avi
> >
> I'll check it.
> 
> how /over what did you meassure the 3% exactly ?
> > iam asking, so i understand if this performance chnage is irrelevant
> > or not.
> > for init code that runs once some speed loss is irrelevant but for
> > example the horizontal scale code as a whole should not become 3%
> > slower.
> > but i do not suggest to do non trivial optimization on this yet.
> > better get it all working first.
> 
> The measurement was done only for the horizontal scaling loop.
> But it should improve without much effort  when the implementation advance.
> 
> please always attach patches, that makes reviewing them with with
> > MUAs easy and also keeps them together with any discussions about
> > them. who knows if the github links will still work in 10 years if
> > someone tries to debug something and tried to look up old discussions
> > and patches ...
> >
> Attached.

For this it would be really better if you sent the patches with git
send-email. It sends 1 patch per mail, and makes it much easier to read
and review. Once you've learned how to do it, it'll be much easier for
you as well.