[FFmpeg-devel] [libav-devel] [PATCH 2/2] lavf: move internal fields from public to internal context

[Michael Niedermayer]

Hi

On Thu, Mar 05, 2015 at 10:15:51AM +0100, Bálint Réczey wrote:
> Hi,
> 
> 2015-03-05 0:02 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
> > On 04.03.2015 23:13, Luca Barbato wrote:
> >>
> >> On 04/03/15 21:49, Andreas Cadhalpun wrote:
> >>>
> >>> So what do you think about resurrecting this patch (add avformat_flush)?
> >>
> >>
> >> I see no patch about it, my email client chewed it?
> >
> >
> > It has been a while ago [1]. It just adds a public API for
> > ff_read_frame_flush.
> >
> >>> It seems to have only stalled on the associated documentation and the
> >>> XBMC developers are apparently not the only ones who would find it
> >>> useful.
> >>
> >>
> >> The function is useful if somebody wants to implement some custom seek
> >> and in order to do that probably is using some of the fields being
> >> hidden so I'm not sure just exposing that function would do anything
> >> good for that use case.
> >>
> >> I'd rather check with the XBMC (I guess now the name is Kodi, let's try
> >> to move to use the new name) people why they need it and if the problem
> >> they have with the seeking functions can't be solved otherwise.
> >
> >
> > To me it seems that this is the only internal API they need, but asking
> > can't hurt. So CC'ing the Debian XBMC/Kodi maintainer.
> I would welcome the resurrection of avformat flush. This is the only
> internal API used by XBMC/Kodi indeed.

ive already applied wm4s patch yesterday, so the next ffmpeg release
(2.6) should contain avformat_flush()

if further changes are needed please tell me

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150305/40253530/attachment.asc>