[FFmpeg-devel] [PATCH] mips/asmdefs: use asm/sgidefs.h header on linux

Michael Niedermayer michaelni at gmx.at
Sat Mar 7 11:22:39 CET 2015


On Sat, Mar 07, 2015 at 10:13:23AM +0000, James Cowgill wrote:
> Unfortunately android < api 21 (lollipop) doesn't have the sgidefs.h header,
> but the linux kernel does in asm/sgidefs.h. So use that header if we can.
> 
> Change _ABI64 to _MIPS_SIM_ABI64 which is defined in both headers.
> 
> Signed-off-by: James Cowgill <james410 at cowgill.org.uk>
> ---
>  libavutil/mips/asmdefs.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/libavutil/mips/asmdefs.h b/libavutil/mips/asmdefs.h
> index 4d2922c..3660e98 100644
> --- a/libavutil/mips/asmdefs.h
> +++ b/libavutil/mips/asmdefs.h
> @@ -27,9 +27,13 @@
>  #ifndef AVCODEC_MIPS_ASMDEFS_H
>  #define AVCODEC_MIPS_ASMDEFS_H
>  
> +#ifdef __linux__
> +#include <asm/sgidefs.h>
> +#else
>  #include <sgidefs.h>
> +#endif

is it possible to to test for the header in configure instead of
testing for __linux__
we test for most other headers in configure

see, for example "check_header asm/types.h" / "#if HAVE_ASM_TYPES_H"

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150307/4c09f106/attachment.asc>


More information about the ffmpeg-devel mailing list