[FFmpeg-devel] avfilter/af_astats: Avoid Zero division in print part.

Paul B Mahol onemda at gmail.com
Sun Mar 8 10:46:28 CET 2015


On 3/8/15, Nicolas George <george at nsup.org> wrote:
> L'octidi 18 ventose, an CCXXIII, Paul B Mahol a ecrit :
>> Yes, it gives me floating exception. Looks like uninit() is called
>> unconditionally.
>
> Of course uninit() is called unconditionally. But it should not crash, and
> I
> re-checked here and it does not crash indeed.
>
> This change seems very wrong to me, you have the very same divide-by-zero
> in
> the per-channel case, just above your test, there is no reason for one to
> crash and not the other.

You mean for case when there are channels present but without any
samples? For example nb_channels = 2 and nb_samples = 0?
>
> Regards,
>
> --
>   Nicolas George
>


More information about the ffmpeg-devel mailing list