[FFmpeg-devel] [PATCH 5/8] ffmdec: break infinite resync loop

Michael Niedermayer michaelni at gmx.at
Mon Mar 9 03:13:24 CET 2015


On Mon, Mar 09, 2015 at 12:04:13AM +0100, Andreas Cadhalpun wrote:
> Hi,
> 
> some broken files can lead to an endless resync loop, which is
> avoided by attached patch.
> 
> Best regards,
> Andreas

>  ffmdec.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 048852d2d9b0c25157015a4befd76323fc4b2cc6  0005-ffmdec-break-infinite-resync-loop.patch
> From 5682ffffa0cafbaf9339352f3147ef7c494dea47 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Sun, 8 Mar 2015 23:29:42 +0100
> Subject: [PATCH 5/8] ffmdec: break infinite resync loop
> 
> If resyncing leads to the same position as previously, it will again
> lead to a resync attempt, resulting in an infinite loop.

iam not sure this is sufficient and loops over more than 1 resync
point arent possible
maybe its better to never allow resync to start before
or at the previous resync point

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150309/0fc5ecff/attachment.asc>


More information about the ffmpeg-devel mailing list