[FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

[Michael Niedermayer]

On Mon, Mar 09, 2015 at 12:55:43PM -0300, Claudio Freire wrote:
> On Mon, Mar 9, 2015 at 12:41 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Mar 08, 2015 at 11:07:33PM -0300, Claudio Freire wrote:
> >> On Sun, Mar 8, 2015 at 11:06 PM, Claudio Freire <klaussfreire at gmail.com> wrote:
> >> > On Sun, Mar 8, 2015 at 8:23 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> >> i think its better to leave fuzz at a small value otherwise we
> >> >> would forget to update the target when it improves and then
> >> >> subsequent worsenings could be missed
> >> >
> >> > An updated version with that fixed.
> >> >
> >> > It's a bit tricky to squash commits with git format-patch, so if
> >> > there's an issue with the patch just apply it with patch -p1, works
> >> > that way (tried)
> >>
> >>
> >> Dang, forgot to attach the patch.
> >>
> >> Now truly attached.
> >
> > works on x86 but fails on mips:
> >
> > stddev:  443.22 PSNR: 43.40 MAXDIFF: 5038 bytes:   176400/   180224
> > stddev: |443.22 - 414| >= 5
> > Test aac-s7350-encode failed. Look at tests/data/fate/aac-s7350-encode.err for details.
> 
> That's weird. I didn't expect this code to be platform-specific.
> 

> Head is still using a butterworth filter for the lowpass IIRC. That
> could very well be both platform and sample rate specific.
> 
> Sadly, I cannot test mips, but commenting the lowpass could yield
> useful results.

what exact change should i make / can you provide a diff?
what exact should i test / can you provide a command line ?


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150309/94f654ab/attachment.asc>