[FFmpeg-devel] [PATCH] lavfi: Add support to process_command in vf_eq.c

Stefano Sabatini stefasab at gmail.com
Tue Mar 10 10:47:48 CET 2015


On date Monday 2015-03-09 19:54:57 +0530, Arwa Arif encoded:
> I was going through the code, and I realized that I have made a mistake. I
> have corrected the code, and attached the corresponding patch.

> From 2ebd299b55a34914d5549f21d264e8cb7f5f605d Mon Sep 17 00:00:00 2001
> From: Arwa Arif <arwaarif1994 at gmail.com>
> Date: Mon, 9 Mar 2015 19:50:32 +0530

> Subject: [PATCH] Fix the wrong parsing style in vf_eq

lavfi/eq: fix ...

> 

> blah

?

Please explain what's wrong with the current code in the commit log,
and be more explicit in the subject.

> ---
>  libavfilter/vf_eq.c |   33 ++++++++++++++++-----------------
>  libavfilter/vf_eq.h |   34 ++++++++--------------------------
>  2 files changed, 24 insertions(+), 43 deletions(-)

Also, I think retaining expression parameters may be useful if you add
meaningful parameters (e.g. time, as in hue).

[...]
-- 
FFmpeg = Forgiving and Fanciful Martial Pitiless Erotic Guru


More information about the ffmpeg-devel mailing list