[FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

[Michael Niedermayer]

On Thu, Mar 12, 2015 at 08:13:53PM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2015-03-11 17:06 GMT+01:00 James Almer <jamrial at gmail.com>:
> > As discussed before, mmx, mmxext and sse functions that have also an sse2 version, and
> > 3dnow/3dnowext functions that have also an sse version, have no reason to exist in an
> > x86_64 build.
> 
> I think the reason may have been someone tinkering on some parts, and
> testing them, could still see he broke the MMX versions.
> 
> On the other hand, that someone should really test on the appropriate
> platform, which is easy on x86.
> 
> > They will not be used in any real world scenario.
> 
> Agreed, so I left the restriction.
> 
> Patch updated because of the dct-test stuff.
> 
> Incidentally, I found other issues with dct-test, but they are outside
> the scope of this patch series.
> 
> -- 
> Christophe

>  b/libavcodec/x86/Makefile        |    1 
>  b/libavcodec/x86/dct-test.c      |    8 
>  b/libavcodec/x86/xvididct.asm    |  450 +++++++++++++++++++++++++++++++
>  b/libavcodec/x86/xvididct_init.c |   40 ++
>  libavcodec/x86/xvididct_mmx.c    |  549 ---------------------------------------
>  5 files changed, 484 insertions(+), 564 deletions(-)
> 9f7d1545c7d4b334ccf3dcf290d2787f98c72509  0002-x86-xvid_idct-port-MMX-iDCT-to-yasm.patch
> From 866b481ecab3369712ff854ce6c0857b875b50e6 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Tue, 10 Mar 2015 23:11:52 +0000
> Subject: [PATCH 2/4] x86: xvid_idct: port MMX iDCT to yasm
> 
> Also reduce the table duplication with SSE2 code, remove duplicated
> macro parameters.
> ---
>  libavcodec/x86/Makefile        |   1 -
>  libavcodec/x86/dct-test.c      |   8 +-
>  libavcodec/x86/xvididct.asm    | 450 ++++++++++++++++++++++++++++++++-
>  libavcodec/x86/xvididct_init.c |  40 ++-
>  libavcodec/x86/xvididct_mmx.c  | 549 -----------------------------------------
>  5 files changed, 484 insertions(+), 564 deletions(-)
>  delete mode 100644 libavcodec/x86/xvididct_mmx.c

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150314/8185cd0a/attachment.asc>