[FFmpeg-devel] [PATCH 2/5] x86: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

Michael Niedermayer michaelni at gmx.at
Sat Mar 14 20:23:46 CET 2015


On Sat, Mar 14, 2015 at 07:58:29PM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2015-03-14 19:07 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> >>  #define PR_WRAP(INSN) \
> >>  static void ff_prores_idct_put_10_##INSN##_wrap(int16_t *dst){ \
> >> -    DECLARE_ALIGNED(16, static int16_t, qmat)[64]; \
> >> -    DECLARE_ALIGNED(16, static int16_t, tmp)[64]; \
> >> +    LOCAL_ALIGNED(16, static int16_t, qmat, [64]); \
> >> +    LOCAL_ALIGNED(16, static int16_t, tmp, [64]); \
> >>      int i; \
> >
> > LOCAL_ALIGNED + static looks unintended
> 
> Same fix then.
> 
> Best regards,
> Christophe

>  ac3dsp_init.c  |    2 +-
>  cavsdsp.c      |    4 ++--
>  dct-test.c     |    4 ++--
>  h264_qpel.c    |   22 +++++++++++-----------
>  rv40dsp_init.c |    2 +-
>  vc1dsp_mmx.c   |    2 +-
>  vp8dsp_init.c  |    4 ++--
>  7 files changed, 20 insertions(+), 20 deletions(-)
> d9bbc60366078bf5297a7c79aaf91d3ac3cc09d4  0002-x86-lavc-use-LOCAL_ALIGNED-instead-of-DECLARE_ALIGNE.patch
> From 93a8d803f6b87e2c5bd062724630e1d67804da29 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Sat, 14 Mar 2015 14:30:18 +0100
> Subject: [PATCH 2/3] x86: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED
> 
> The later may yield incorrect code for on-stack variables.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150314/937227f5/attachment.asc>


More information about the ffmpeg-devel mailing list